Tgr added a comment.
At a glance, the methods which will break if `mParent` is not set are - HTMLFormField::getErrorsAndErrorClass <https://github.com/wikimedia/mediawiki/blob/30aaec7b506e38ae628bbfd3b133bf43d58f12c1/includes/htmlform/HTMLFormField.php#L806>, HTMLFormField::getErrorsRaw <https://github.com/wikimedia/mediawiki/blob/30aaec7b506e38ae628bbfd3b133bf43d58f12c1/includes/htmlform/HTMLFormField.php#L827> and HTMLFormField::getLabelHtml <https://github.com/wikimedia/mediawiki/blob/30aaec7b506e38ae628bbfd3b133bf43d58f12c1/includes/htmlform/HTMLFormField.php#L865> - HTMLButtonField::getInputHTML <https://github.com/wikimedia/mediawiki/blob/30aaec7b506e38ae628bbfd3b133bf43d58f12c1/includes/htmlform/HTMLButtonField.php#L59> - HTMLCheckMatrix::getOneCheckbox <https://github.com/wikimedia/mediawiki/blob/30aaec7b506e38ae628bbfd3b133bf43d58f12c1/includes/htmlform/HTMLCheckMatrix.php#L158> (eventually called from getInputHTML) and HTMLCheckMatrix::loadDataFromRequest <https://github.com/wikimedia/mediawiki/blob/30aaec7b506e38ae628bbfd3b133bf43d58f12c1/includes/htmlform/HTMLCheckMatrix.php#L228> - HTMLFormFieldCloner::getInputHTMLForKey <https://github.com/wikimedia/mediawiki/blob/30aaec7b506e38ae628bbfd3b133bf43d58f12c1/includes/htmlform/HTMLFormFieldCloner.php#L263> (called from getInputHTML) - HTMLHiddenField::getTableRow <https://github.com/wikimedia/mediawiki/blob/30aaec7b506e38ae628bbfd3b133bf43d58f12c1/includes/htmlform/HTMLHiddenField.php#L33> - HTMLMultiSelectField::getOneCheckbox <https://github.com/wikimedia/mediawiki/blob/30aaec7b506e38ae628bbfd3b133bf43d58f12c1/includes/htmlform/HTMLMultiSelectField.php#L93> - HTMLSelectLimitField::validate <https://github.com/wikimedia/mediawiki/blob/30aaec7b506e38ae628bbfd3b133bf43d58f12c1/includes/htmlform/HTMLSelectLimitField.php#L28> - HTMLTitleTextField::validate <https://github.com/wikimedia/mediawiki/blob/30aaec7b506e38ae628bbfd3b133bf43d58f12c1/includes/htmlform/HTMLTitleTextField.php#L34> and HTMLTitleTextField::getInputWidget <https://github.com/wikimedia/mediawiki/blob/30aaec7b506e38ae628bbfd3b133bf43d58f12c1/includes/htmlform/HTMLTitleTextField.php#L76> - HTMLUserTextField::getInputWidget <https://github.com/wikimedia/mediawiki/blob/30aaec7b506e38ae628bbfd3b133bf43d58f12c1/includes/htmlform/HTMLUserTextField.php#L43> and HTMLUserTextField::getInputHtml <https://github.com/wikimedia/mediawiki/blob/30aaec7b506e38ae628bbfd3b133bf43d58f12c1/includes/htmlform/HTMLUserTextField.php#L50> TASK DETAIL https://phabricator.wikimedia.org/T134351 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Urbanecm, TerraCodes, Tgr, Anomie, Luke081515, gerritbot, Aklapper, Zppix, Tobi_WMDE_SW, aude, hoo, JanZerebecki, Lydia_Pintscher, thiemowmde, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
