[Wikidata-bugs] [Maniphest] [Commented On] T133381: Add support for foreign entities to EntityId

Tue, 13 Sep 2016 07:14:30 -0700

daniel added a comment.

When adding support for the repo prefix to EntityId, please note the following points:

  • the string returned by getSerialization() should include the prefix.
  • equals() should consider the prefix.

New methods to add:

  • getRepoName() (or getRepoPrefix, or getOrigin, or...); returns "" for the local repo.
  • getLocalPart() (this might not even be needed, but nice to have)
  • isForeign() (to check and fail in some critical code pathes)

TASK DETAIL
https://phabricator.wikimedia.org/T133381

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: Jakob_WMDE, WMDE-leszek, Ricordisamoa, jayvdb, aude, JeroenDeDauw, Jonas, JanZerebecki, adrianheine, thiemowmde, Aklapper, daniel, D3r1ck01, Izno, Wikidata-bugs, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to