hoo added a comment.

How big is the difference between the two SQL queries?

Significant. The old query used an indexed integer column for joining, while the new uses a REPLACE() on a column for joining.

Can't we optimize it more?

I can't see how we can optimize it more with the current wb_terms table structure.

Is the difference really that relevant for two special pages that nobody uses anyway?

Probably not, that's why we remove the support for Items. The new query might be so bad that it could be used in a harmful way if you have the possibility to trigger scanning multiple million rows.


TASK DETAIL
https://phabricator.wikimedia.org/T147638

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hoo
Cc: thiemowmde, Zppix, Aklapper, gerritbot, Izno, hoo, Lydia_Pintscher, daniel, D3r1ck01, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to