thiemowmde added a comment.

As discussed, I fully support the idea of data attributes, microformats and such. But:

  • We must drop the EscapingSnakFormatter in the DataAccessSnakFormatterFactory anyway, and create one that understands these semantics. We will rethink lots of things anyway when we do this.
  • I believe this new formatter must still ignore empty values, and never output empty elements. There is nothing the user can do with it, if it does not have a label. Note that the main purpose of the output this new code produces is to be meaningful to the user. Being machine readable is a bonus.
  • Currently this is required, otherwise we would render weird stuff like "A, , C, ". An option would be to check for '<span></span>' when joining the list with commas, but I do not like the idea of code that tries to detect empty HTML elements.
  • Let's say we give users the option to output an HTML list. Rendering an <li> with an empty <span> can not be done, I believe (possibly as an option, but not by default). So where would the empty span go instead? After the list? I find this weird. Better not output it.

TASK DETAIL
https://phabricator.wikimedia.org/T147307

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hoo, thiemowmde
Cc: Izno, Aklapper, Lydia_Pintscher, daniel, aude, Lucie, thiemowmde, hoo, D3r1ck01, Wikidata-bugs, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to