Sumit added a comment.

I agree and I'm regretful that I wasn't more verbose in that task. If I created it, I suspect there was a good reason - e.g. a discussion on Wikivoyage or there was a technical barrier to doing so. Hoping we can shed some light on the issue and get it fixed. Thanks for reporting it!

@Jdlrobson is there a way to look up past Traveller's pub discussions? I guess we did this because the diff for banners was not making sense( there would be only one banner image ), but I'm not so sure.

@Andyrom75 I think that's fine. It may be tricky to fix however as 1) I need to find someone to work on this problem or review a patch from me and 2) the title of the page does not currently appear in the diff.

Regarding 2), T110384 says:

On reflection given that the page headings do not render in revisions and the banner is substitution for the heading I actually think this is the correct behaviour. For instance the heading "Download" does not show up in https://www.mediawiki.org/w/index.php?title=Download&type=revision&diff=1896349&oldid=1813316

I'll submit a patch to this once I get back home ( after 6th ).


TASK DETAIL
https://phabricator.wikimedia.org/T147946

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sumit
Cc: Tgr, Nicolas_Raoul, Sumit, Jdlrobson, Aklapper, Andyrom75, Winter, Wikidata-bugs, Lydia_Pintscher
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to