thiemowmde added a comment.

The current order is in http://www.wikidata.org/wiki/MediaWiki:Wikibase-SortedProperties.

These are the formats I want a parser (the current one is in WikiTextPropertyOrderProvider) to accept:

== Have sections (they are just ignored) ==
* P1
* P1 (foo)
* [[Property:P1]]
* [[Property:P1|P1]]
* [[d:Property:P1|P1]]
* {{P|1}}
* {{P|P1}}

Things I find critical:

  • Add much more test cases to the parser (see the list of formats above) and make is as robust as possible. But don't make it to "clever". It should behave in a way that's easy to understand.
  • Write documentation for this parser.
  • Do some benchmarking to make sure the re-ordering succeeds in a few milliseconds, and there are no worst cases.
  • What happens is the parser entirely fails and returns an empty list? Is there a way we can make the community aware of such a situation?
  • All code should be robust and work just fine when there is no order (null or an empty array) for some reason.
  • The caching is fine as far as I can tell. See CachingPropertyOrderProvider.

@Lydia_Pintscher: As discussed, support for overriding the order in ArticlePlaceholder on each local wiki should be tracked in a separate ticket.


TASK DETAIL
https://phabricator.wikimedia.org/T150788

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: thiemowmde, Aklapper, Lydia_Pintscher, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to