[Wikidata-bugs] [Maniphest] [Created] T151577: Do not call Entity::setId() with an int parameter

Thu, 24 Nov 2016 10:20:06 -0800

daniel created this task.
daniel added projects: Wikidata, MediaWiki-extensions-WikibaseRepository, Technical-Debt, Wikidata-Sprint-2016-11-15.
Herald added a subscriber: Aklapper.

TASK DESCRIPTION

Implementations of Entity::setId() should require an EntityId as a parameter. At present, they also support int parameters, and then create the appropriate EntityId internally. Besides this being a nasty B/C hack, it does not work for foreign IDs.

Support for numeric IDs can be removed from Entity::setId() by making all callers that use an integer construct an EntityId first, using the EntityIdComposer service. In particular, this is the case for WikiPageEntityStore::assignFreshId().


TASK DETAIL
https://phabricator.wikimedia.org/T151577

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: Aklapper, daniel, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to