| daniel added a comment. |
Without looking at the code, it seems we should be able to do without Database::lockIsFree. It's nice to do a check first to avoid a more expensive attempt to acquire a lock if we already know that that is likely to fail, but in the end, all we need is an atomic way to try to grab a lock, and then know if we got it.
One thing that is important in this context is how stale locks are handled. Does redis know if the owner of a lock has died? Or an orphaned lock stay around forever? Do locks time out?
TASK DETAIL
EMAIL PREFERENCES
To: Ladsgroup, daniel
Cc: gerritbot, Ladsgroup, hoo, Lydia_Pintscher, Jonas, Aklapper, jcrespo, Marostegui, daniel, aaron, Th3d3v1ls, Ramalepe, Liugev6, Vali.matei, Lewizho99, Minhnv-2809, Maathavan, D3r1ck01, Izno, Luke081515, Wikidata-bugs, aude, GWicke, Mbch331, Jay8g, Krenair
Cc: gerritbot, Ladsgroup, hoo, Lydia_Pintscher, Jonas, Aklapper, jcrespo, Marostegui, daniel, aaron, Th3d3v1ls, Ramalepe, Liugev6, Vali.matei, Lewizho99, Minhnv-2809, Maathavan, D3r1ck01, Izno, Luke081515, Wikidata-bugs, aude, GWicke, Mbch331, Jay8g, Krenair
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
