| daniel created this task. daniel added projects: MediaWiki-extensions-WikibaseRepository, Wikidata, Wikidata-Sprint-2016-11-15. Herald added a subscriber: Aklapper. |
TASK DESCRIPTION
Both WikibaseClient::newTermSearchInteractor and WikibaseRepo::newTermSearchInteractor should return a DispatchingTermSearchInteractor. They should get that instance from DispatchingServiceFactory.
Note that newTermSearchInteractor is currently guaranteed to always return a fresh instance, which does not fit with how ServiceContainer handles service instances. One solution would be to make createService() protected in ServiceContainer, and call that in DispatchingTermSearchInteractor::newTermSearchInteractor. But perhaps it's not actually required to always have a fresh interactor instance. Maybe we can change the method to lazy getter semantics, and rename it to getTermSearchInteractor. A third option is to introduce a factory.
TASK DETAIL
EMAIL PREFERENCES
To: daniel
Cc: Aleksey_WMDE, Jakob_WMDE, WMDE-leszek, Aklapper, daniel, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331
Cc: Aleksey_WMDE, Jakob_WMDE, WMDE-leszek, Aklapper, daniel, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
