hoo created this task.
hoo added projects: Wikidata, Wikibase-DataModel-Serialization.
Herald added a subscriber: Aklapper.

TASK DESCRIPTION

That function is being called a lot when for example generating dumps (once for each of our 130M+ statements), and I found it to be rather slow (when profiling the dumpers locally).

By just inlining some of the function calls it does (or even just the ifs in the functions called by getDeserialized), we can probably gain a significant speedup.
During some playing around, I managed to get a speedup of about 6-7% when inlining getDeserialized into deserialize and by pulling the initial guard ifs from the set… functions up into the calling code.


TASK DETAIL
https://phabricator.wikimedia.org/T157013

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hoo
Cc: JeroenDeDauw, daniel, Aklapper, hoo, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to