daniel added a comment.

The issue here is two-fold:

  1. the EntityIdHtmlLinkFormatter needs to get the correct LabelDescriptionLookup - one that can handle multiple repositories. FormatterLabelDescriptionLookupFactory is responsible for providing this instance. In an EntityView, this will be based on an EntityInfoTermLookup, which leads to the problem of creating an EntityInfoBuilder that can handle federation. I filed T157363 for this.
  2. EntityIdHtmlLinkFormatter needs to correctly handle the fact that a) TitleLookup::getTitleForId may return null, and b) Title::exists() returns false for interwiki titles. So, the existance check should be skipped if the title is not local, and getTitleForId returning null should be treated as if the entity was missing (as if exists() returned false).

TASK DETAIL
https://phabricator.wikimedia.org/T157003

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: daniel, Aklapper, Lydia_Pintscher, WMDE-leszek, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to