| daniel added a comment. |
Not sure this is still relevant. LegacyIdInterpreter seems to only be used in backwards-compat code now, which is restricted to Items and Properties. It's used in:
- EntityIdValue, for the legacy serialization format (which only exists for items and properties)
- LegacyEntityIdDeserializer, which only supports items and properties
- EntityContentDataCodec, for decoding the old style representation of entity IDs, which was only ever used for items and properties.
So these all seem fine. Perhaps LegacyIdInterpreter could be re-implemented based on EntityIdComposer, or EntityIdComposer could have a static getLegacyIdComposer method, that would return a EntityIdComposer instance for just items and properties.
TASK DETAIL
EMAIL PREFERENCES
To: daniel
Cc: WMDE-leszek, thiemowmde, Aklapper, daniel, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g
Cc: WMDE-leszek, thiemowmde, Aklapper, daniel, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
