[Wikidata-bugs] [Maniphest] [Created] T158941: Wikibase: Fix tests to not assume synchronous jQuery.Deferred

[Krinkle]

Krinkle created this task. Krinkle added projects: _javascript_, Wikibase-DataModel-_javascript_, Wikidata. Herald added a subscriber: Aklapper.

TASK DESCRIPTION

Draft change with details at https://gerrit.wikimedia.org/r/323445/.

Each QUnit test should either return a Promise to QUnit.test (which QUnit will automatically wait for and also report a test failure if the Promise is rejected), or manually use assert.async() where needed.

Examples:

QUnit.test( 'example should pass', function ( assert ) {
  return something().then( function ( val ) {
    assert.equals( val, 'expected' );
  } );
} );

QUnit.test( 'example should fail', function ( assert ) {
  var done = assert.async();
  something().fail( function ( val ) {
    assert.equals( val, 'error message' );
  } ).always( done );
} );

This is in preparation for jQuery 3.0, where $.Deferred callbacks are processed asynchronously. https://jquery.com/upgrade-guide/3.0/

Failures can be seen at the pending core patch: https://gerrit.wikimedia.org/r/322812/.

TASK DETAIL

https://phabricator.wikimedia.org/T158941

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Aklapper, Krinkle, enigmaeth, rohitt, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331

_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs