| thiemowmde closed this task as "Declined". thiemowmde removed a project: Wikidata-Sprint. thiemowmde added a comment. |
All linked patches got revoked. We followed the wrong route there.
It's not the job of SerializerFactory to hold EntitySerializers for all configured entity types. The SerializerFactory we are talking about lives in the #wikibase-datamodel-serialization component, which holds serializers for the two base entity types in #wikibase-datamodel.
We always need a separate EntitySerializer in the top level factory that knows about all entity types, and should properly cache this. This is already the case. Refactorings are always possible, but I don't see a pressing need for the refactoring proposed in this ticket.
TASK DETAIL
EMAIL PREFERENCES
To: thiemowmde
Cc: thiemowmde, Aklapper, daniel, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331
Cc: thiemowmde, Aklapper, daniel, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
