| gerritbot added a comment. |
Change 337045 abandoned by Thiemo Mättig (WMDE):
Use EntityIdComposer instead EntityId::newFromNumber in client
Reason:
Using the composer only makes sense if either the entity type is variable, or the repo prefix is (or if there is a chance we will make one of it variable in the near future). Neither is the case here. We know the repo prefix is empty. We know the type is "item". Nothing wrong with using the static constructor then. The "wb_items_per_site" table that is used here (via SiteLinkTable) does not support repo prefixes, and as far as I know it does not need to.
TASK DETAIL
EMAIL PREFERENCES
To: Ladsgroup, gerritbot
Cc: gerritbot, WMDE-leszek, thiemowmde, Aklapper, daniel, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g
Cc: gerritbot, WMDE-leszek, thiemowmde, Aklapper, daniel, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
