| Krinkle added a comment. |
- Current For gate-and-submit we end up triggering:
Job name Description npm-node-6-jessie _javascript_ lint/style and others composer-php55-trusty lint/style composer-hhvm-jessie lint/style php55lint Lint on permanent slave. Composer already run parallel-lint mwext-testextension-php55-composer-trusty PHPUnit mwext-testextension-hhvm-composer-jessie PHPUnit mwext-qunit-composer-jessie QUnit tests with Karma mwext-mw-selenium-composer-jessie Browser tests based on ruby/selenium
Job name App DB PHP mwext-Wikibase-repo-tests-sqlite-php55-trusty Repo sqlite php55 mwext-Wikibase-repo-tests-sqlite-hhvm-jessie Repo sqlite HHVM mwext-Wikibase-client-tests-mysql-php55-trusty Client MySQL php55 mwext-Wikibase-client-tests-sqlite-php55-trusty Client sqlite php55 mwext-Wikibase-client-tests-mysql-hhvm-jessie Client Mysql HHVM mwext-Wikibase-client-tests-sqlite-hhvm-jessie Client sqlite HHVM
Propose to change:
- mwext-testextension-php55-composer-trusty include composer test (for lint/style)
- mwext-testextension-hhvm-composer-trusty include composer test (for lint/style)
- Merge mwext-Wikibase-repo-* and mwext-Wikibase-client-* tests.
Propose to remove:
- php55lint (redundant with composer-php55-trusty)
- composer-php55-trusty (redundant with mwext-testextension-php55-composer-trusty)
- composer-hhvm-jessie (redundant with mwext-testextension-hhvm-composer-trusty)
- all 6 mwext-Wikibase-*-tests-* jobs. Redunant with mwext-testextension-*-composer-*.
Propose to add:
- mwext-testextension-hhvm-sqlite-composer-trusty to ensure sqlite is covered in addition to mysql. No need to cover it with both hhvm and php55.
Questions:
- What is the difference between mwext-Wikibase-*-tests-* and mwext-testextension-*-composer-*? It seems like the latter already runs all PHPUnit tests (both client and repo). It also varies by PHP flavour already, but not by RDBMS. It would make sense to add a third variation to sqlite with one of the PHP flavours.
| Job name | Description |
|---|---|
| npm-node-6-jessie | _javascript_ lint/style and others |
| mwext-Wikibase-tests-php55-mysql | Composer test (lint, style, PHPUnit) |
| mwext-Wikibase-tests-hhvm-mysql | Composer test (lint, style, PHPUnit) |
| mwext-Wikibase-tests-hhvm-sqlite | Composer test (lint, style, PHPUnit) |
| mwext-qunit-composer-jessie | QUnit tests with Karma |
| mwext-mw-selenium-composer-jessie | Browser tests based on ruby/selenium |
This means a small amount is duplicated (2x lint/style for HHVM) but that seems marginal and unimportant, given they run in parallel anyway.
TASK DETAIL
EMAIL PREFERENCES
To: Krinkle
Cc: Krinkle, Paladox, Ladsgroup, greg, Tobi_WMDE_SW, daniel, Lydia_Pintscher, Addshore, thcipriani, hashar, Aklapper, QZanden, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g
Cc: Krinkle, Paladox, Ladsgroup, greg, Tobi_WMDE_SW, daniel, Lydia_Pintscher, Addshore, thcipriani, hashar, Aklapper, QZanden, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
