[Wikidata-bugs] [Maniphest] [Commented On] T158941: Wikibase: Fix tests to not assume synchronous jQuery.Deferred

Wed, 05 Apr 2017 15:53:39 -0700

Krinkle added a comment.

Change 344405 merged by Hoo man:
[mediawiki/extensions/Wikibase@master] Replace QUnit.start()/.stop() with assert.async()

https://gerrit.wikimedia.org/r/344405

What's outstanding here?

From commenets on https://gerrit.wikimedia.org/r/344405:

@Jonas wrote:

@Krinkle this is what you need for all Wikibase tests right?

@Krinkle wrote:

LGTM, but there are a few more failures remaining still at https://gerrit.wikimedia.org/r/#/c/322812/
11 FAILURES:

  • wikibase.entityChangers.EntityTermsChanger save performs correct API calls for new label
  • ..8 similar failures
  • wikibase.entityChangers.SiteLinkSetsChanger save performs correct API call FAILED
  • wikibase.entityChangers.SiteLinkSetsChanger save performs correct API call for removal FAILED
@Jonas wrote:

I just wanted to check if that is the fix you need, before I fix all the places needed [..]

So, similar to the first patch, this converted a few tests but there are still a handful left using the unsupported format.

FAILED TESTS:
  wikibase.entityChangers.EntityTermsChanger
    ✖ save performs correct API calls for new label
    failed, expected argument to be truthy, was: false

    ✖ save performs correct API calls for changed label
    failed, expected argument to be truthy, was: false

    ✖ save performs correct API calls for removed label
    failed, expected argument to be truthy, was: false

    ✖ save performs correct API calls for new description
    failed, expected argument to be truthy, was: false

    ✖ save performs correct API calls for changed description
    failed, expected argument to be truthy, was: false

    ✖ save performs correct API calls for removed description
    failed, expected argument to be truthy, was: false

    ✖ save performs correct API calls for new aliases
    failed, expected argument to be truthy, was: false

    ✖ save performs correct API calls for changed aliases
    failed, expected argument to be truthy, was: false

    ✖ save performs correct API calls for removed aliases
    failed, expected argument to be truthy, was: false

  wikibase.entityChangers.SiteLinkSetsChanger
    ✖ save performs correct API call
    failed, expected argument to be truthy, was: false

    ✖ save performs correct API call for removal
    failed, expected argument to be truthy, was: false

  jquery.wikibase.entitytermsforlanguagelistview
    ✖ Create & destroy
    afterEach failed on Create & destroy: Unfinished animations: 2
    Error: Unfinished animations: 2

    ✖ setError()
    afterEach failed on setError(): Unfinished animations: 2
    Error: Unfinished animations: 2

TASK DETAIL
https://phabricator.wikimedia.org/T158941

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jonas, Krinkle
Cc: Jdforrester-WMF, thiemowmde, Jonas, Lydia_Pintscher, gerritbot, Aklapper, Krinkle, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, Salgo60, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to