Smalyshev added a comment.

@cscott The Wikibase code looks at LanguageConverter::$languagesWithVariants. The problem is that before the patch that list did not contain en but now it does. And depending on whether the language is there or not, getParentLanguage() for en returns different results - it returned null before, but with the patch it returns object for en so English is parent of itself now. The description of FALLBACK_VARIANTS suggests that's what languages with variants should do, but not what languages without variants do. The problem seems to be Wikibase assumes en is the latter, but the patch changes it to the former.

I'm not sure it's a good idea to have certain languages behave completely different from others on the same calls, but that's how the code seems to go now.


TASK DETAIL
https://phabricator.wikimedia.org/T156280

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Smalyshev
Cc: daniel, hoo, aude, Lydia_Pintscher, thiemowmde, Smalyshev, Aklapper, cscott, QZanden, Izno, Wikidata-bugs, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to