daniel added a comment.

I would extend this to constructors of all Entities. And I think removing all parameters from all the constructors would be best. We can perhaps keep the optional ID parameter, but even that isn't very useful.

If we do this, the EntityDocument interface should get an isFullyInitialized method, which we should check as a postcondition in EnityDeserializers, and as a precondition in EntitySerializers.


TASK DETAIL
https://phabricator.wikimedia.org/T162809

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde, daniel
Cc: gerritbot, Jakob_WMDE, Ladsgroup, Lydia_Pintscher, daniel, Aleksey_WMDE, Jonas, WMDE-leszek, thiemowmde, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to