Ladsgroup added a subscriber: Anomie.
Ladsgroup added a comment.

Yes, Right now three special pages use SpecialWikibaseQueryPage:

  • SpecialEntitiesWithoutPage
  • SpecialListProperties
  • SpecialItemsWithoutSitelinks

And three use QueryPage:

  • SpecialEntityUsage
  • SpecialUnconnectedPages
  • SpecialPagesWithBadges

(These three are actually recently writte/rewritten)

Making SpecialWikibaseQueryPage subclass QueryPage and enable proper caching (IIRC @Anomie said caching in QueryPage is actually enabled when 'value' field is added to the query spec, otherwise it's useless. There might be more to it. He knows better)
Here's my suggestion: Let's abandon SpecialWikibaseQueryPage and use QueryPage in these three classes instead. We probably need to rewrite most parts to get it done properly (so we would have caching). But that's definitely something that other Wikidata developers should comment too.


TASK DETAIL
https://phabricator.wikimedia.org/T67168

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Anomie, Ladsgroup, Wikidata-bugs, Tobi_WMDE_SW, JeroenDeDauw, adrianheine, Multichill, Lydia_Pintscher, Reedy, QZanden, Izno, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to