| hoo added a comment. |
In T163748#3208792, @thiemowmde wrote:The semantics of Title::isDeleted seem to be utterly broken. It does not say if a page is currently deleted, but if there was ever a revision deleted, and how much. Can we please deprecate this shit and rename it to hasDeletedRevisons or something?
Yes, that's the root of the problem here: Title::isDeleted is true (well an integer over 0) if there are deleted revisions for a page, no matter whether the page currently exists (which is very counter intuitive). Thus setting EDIT_NEW (which says we that only page creation is allowed) based on Title::isDeleted can lead to the problems described here.
TASK DETAIL
EMAIL PREFERENCES
To: hoo
Cc: thiemowmde, gerritbot, Aklapper, hoo, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331
Cc: thiemowmde, gerritbot, Aklapper, hoo, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
