Lucas_Werkmeister_WMDE added a comment.

So instead of the setXyzServices call in the constructor, the constructor should accept the services as parameters. Should a newFromGlobalState function also be added to the pages, which would do roughly what the constructor does now? That’s what I’ve seen in WikibaseQualityConstraints, but as far as I can tell, it might not be necessary here, since repo/Wikibase.php can call the constructor with the right arguments when it sets up the special pages.


TASK DETAIL
https://phabricator.wikimedia.org/T162540

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, daniel, Aklapper, Lydia_Pintscher, Ladsgroup, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Jay8g
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to