daniel added a comment.

@thiemowmde Whether the diff view code for EntityContent is called or not depends on which way you ask for the diff. When comparing two different kinds of content, it's unclear which diff code to use - that's exactly the reason the exception is thrown.

The real solution to this problem would be to throw a more specific exception in this case, and catch it in Article or DifferenceEngine, and show a nice message. Or catch the condition earlier, before it triggers an exception, in Article or DifferenceEngine.


TASK DETAIL
https://phabricator.wikimedia.org/T52202

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: thiemowmde, hoo, aude, Addshore, Bugreporter, Ricordisamoa, Aklapper, Jasper, Legoktm, Lydia_Pintscher, daniel, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Jackmcbarn, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to