| daniel added a comment. |
One crucial question in this context is when and where the "fake" labels and descriptions would be generated. Where is the logic that maps an Entity to its display label and display description? Should this be in the entity itself?
One may think that this could also be done during the lookup, in the LabelDescriptionLookup. But that will not work, at least not for labels, because we want to support lookup by label. In order to allow an efficient lookup (in a database table or in Elastic), the label has to be pre-generated during indexing.
So, when storing an entity, we should always derive its label and description (and, for the search index, also aliases). As far as I can see, the use cases we have for "display labels" are the same use cases we have for the wb_terms table (and EntityRetrievingTermLookup): lookup of labels (and descriptions) and lookup by label (and aliases).
Cc: Jakob_WMDE, WMDE-leszek, Jonas, Aleksey_WMDE, hoo, aude, Lydia_Pintscher, thiemowmde, Aklapper, daniel, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
