| Aleksey_WMDE added a comment. |
Introduce a SubEntityContainer interface, with methods getSubEntity and setSubEntity.
I don't think it should be done like this. I remember that we discussed that Forms, for example, will have consequent ids (F1, F2, F3, ...) which will be controlled by the Lexeme entity (it'll probably have some counter inside). So getSubEntity method I can see as $lexeme->getSubEntity($formId), but having a setSubEntity method for me doesn't make sense. I would rather have a method addSubSntity(SubEntity $subEntity) explicitly saying what you actually want to do.
Thinking further, I don't see a reason to have addSubSntity method at all, as soon as we will probably need two distinct methods like addForm(Form $form) and addSense(Sense $sense).
TASK DETAIL
EMAIL PREFERENCES
To: Aleksey_WMDE
Cc: aude, Jonas, WMDE-leszek, Aleksey_WMDE, thiemowmde, Aklapper, daniel, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Darkdadaah, Mbch331
Cc: aude, Jonas, WMDE-leszek, Aleksey_WMDE, thiemowmde, Aklapper, daniel, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Darkdadaah, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
