Gehel created this task.
Gehel added a project: Wikidata-Query-Service.
Herald added a subscriber: Aklapper.
Herald added projects: Wikidata, Discovery.

TASK DESCRIPTION

During a recent high edit rate on wikidata, wikidata query service stopped to process updates. The updater logs show:

May 26 10:14:15 wdqs1001 bash[28413]: 10:14:15.070 [TailPoller] INFO  o.w.q.r.t.c.TailingChangesPoller - Caught 477 missing updates, adding to the queue
May 26 10:14:15 wdqs1001 bash[28413]: Exception in thread "TailPoller" java.lang.IllegalStateException: Queue full
May 26 10:14:15 wdqs1001 bash[28413]: at java.util.AbstractQueue.add(AbstractQueue.java:98)
May 26 10:14:15 wdqs1001 bash[28413]: at java.util.concurrent.ArrayBlockingQueue.add(ArrayBlockingQueue.java:312)
May 26 10:14:15 wdqs1001 bash[28413]: at org.wikidata.query.rdf.tool.change.TailingChangesPoller.run(TailingChangesPoller.java:81)

Looking at TailingChangesPoller, it looks like the case where the in ternal poller queue is full is not handled correctly. It might make sense to let the queue block in that case and let it apply back pressure on the producer (see ArrayBlockingQueue.offer()).


TASK DETAIL
https://phabricator.wikimedia.org/T166378

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Gehel
Cc: Smalyshev, Gehel, Aklapper, GoranSMilovanovic, QZanden, EBjune, merbst, Avner, debt, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Deskana, Manybubbles, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to