abian added a comment.

Only 16 constraints on Wikidata actually do that, so in my opinion it’s okay to drop support for this even while we still support constraint templates for a short time (we’ll just quietly ignore the extra properties in a template instead of raising an exception),

+1. In fact, if statements are better supported than templates, the community will definitely stop using these templates, and that's a good thing. 😃

I see three options:

  1. Keep the message exactly as it is, and always supply $2 = 1, $3 = one-element list, $4 = the single required qualifier.
  2. Change the message to “This $1 statement is missing a qualifier $4.”, and document $2 and $3 as dummy/placeholder parameters. For compatibility with old messages, still supply $2 = 1 and $3 = one-element list.
  3. Change the message to “This $1 statement is missing a qualifier $2.”

    I’m not sure what the best option is… perhaps @Amire80 or @abian can comment?

I like the 3 because it leaves the simplest code and documentation. I see no reason to preserve compatibility with the current message.


TASK DETAIL
https://phabricator.wikimedia.org/T167416

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, abian
Cc: Amire80, abian, Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to