| Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality, Wikibase-Quality-Constraints. Herald added a subscriber: Aklapper. |
This line in the constraints CSV is faulty:
32755add-0b0a-494b-9f8c-3a0eb6bda115,227,Qualifiers,"{""property"": ""P1810,P1932,P742,P101,P106,P580,P582,P131P136,P1476,P571,P1269,P518,P1552""}"Note the missing comma between two of the qualifier properties: P131P136. This comes from the following constraint template:
{{Constraint:Qualifiers|list= <!-- person: --> {{P|1810}}, {{P|1932}}, {{P|742}}, {{P|101}}, {{P|106}}, <!-- organization: --> {{P|580}}, {{P|582}}, {{P|131}} <!-- work: --> {{P|136}}, {{P|1476}}, {{P|571}}, {{P|1269}}, <!-- generel: --> {{P|518}}, {{P|1552}} }}The comma is also missing there, but apparently the constraint report bot can deal with that – we can’t.
Previously, the Qualifiers checker used to do a simple string comparison between the qualifier property ID serializations on the statement and the comma-separated properties in the parameters, so (I believe) the only effect was that P131 and P136 qualifiers would erroneously be reported as not permitted. But with the migration to constraint statements, we now do more validation on the constraint parameters even when they’re sourced from statements, so this is now reported as a violation on every P227 statement:
The value for the parameter "property" must be a property, not "P131P136".
What do we want to do about this? We have a couple of options:
- Teach ConstraintParameterParser about this one, particular exception, and backport that fix. (As far as I can’t tell, there aren’t any more non-comma-separated properties in the file (no more matches for [0-9]P).)
- Edit the constraints.csv file to fix the parameters and rerun the import script.
- Fix the constraint on Wikidata and reimport constraints from templates.
- Don’t do anything, since we’ll use constraint statements exclusively soon enough.
Cc: Jonas, Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
