| Lucas_Werkmeister_WMDE added a comment. |
50k is few enough that I have no clear picture of how deprecated rank is actually used on Wikidata, which makes it hard to figure out what makes sense here. It doesn’t help either that only ~400 of those statements have a “reason for deprecation” qualifier. (In fact, there are more normal-rank statements with “reason for deprecation” than actually deprecated ones.)
How about this proposal?
Don’t check constraints on the deprecated statement itself
- Yes: conflicts with, difference within range, inverse, item requires claim, mandatory qualifier, multi value, one of, allowed qualifiers, range, single value, symmetric, value requires claim, type, unique value, value type
- No: Commons link, used as qualifier, used as reference, used as value
Rationale: most constraints are more “logical” / “semantical”, and the deprecated rank already marks the statement as logically / semantically wrong. Commons link, used as qualifier, used as reference, and used as value, on the other hand, are more technical constraints, and should be checked even on those statements.
Ignore deprecated statements when checking the constraint
- Don’t use other statements: Commons link, mandatory qualifiers, allowed qualifiers, one of, range, used as qualifier, used as reference, used as value
- Yes: conflicts with, difference within range, inverse, item requires claim, multi value, single value, symmetric, value requires claim, type, unique value, value type
- No: none?
Do we need any distinctions here?
As it turns out, the checkers for “single value” and “multi value” have been ignoring deprecated statements ever since the baseline commit in which they were first introduced. @Nikki: according to the IRC log, there never was a particular item, and if I’d just quickly checked the source code this issue would never have been opened :/ one example item where you can verify that there’s no “single value” violation is Q12113 (“place of death” statements).
Cc: thiemowmde, Pigsonthewing, Lydia_Pintscher, Ivan_A_Krestinin, Lucas_Werkmeister_WMDE, Nikki, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
