| matmarex added subscribers: Flow, MobileFrontend, VisualEditor, Wikibase. matmarex closed this task as "Declined". matmarex added a comment. |
proactively find the places that are broken and alert the maintainers and guide them with fixing
Okay. I grepped all our code for potential problems:
extensions/Flow/modules/editor/editors/visualeditor/ui/widgets/mw.flow.ve.ui.MentionTargetInputWidget.js: 42: OO.inheritClass( mw.flow.ve.ui.MentionTargetInputWidget, OO.ui.TextInputWidget );
extensions/MobileFrontend/resources/mobile.categories.overlays/CategoryLookupInputWidget.js: 22: OO.inheritClass( CategoryLookupInputWidget, OO.ui.TextInputWidget ); extensions/VisualEditor/lib/ve/src/ui/widgets/ve.ui.WhitespacePreservingTextInputWidget.js: 35: OO.inheritClass( ve.ui.WhitespacePreservingTextInputWidget, OO.ui.TextInputWidget ); extensions/VisualEditor/modules/ve-mw/ui/widgets/ve.ui.MWCategoryInputWidget.js: 41: OO.inheritClass( ve.ui.MWCategoryInputWidget, OO.ui.TextInputWidget ); extensions/WikibaseLexeme/resources/widgets/ItemSelectorWidget.js: 23: OO.inheritClass( ItemSelectorWidget, OO.ui.TextInputWidget );
Dear developers of Flow, MobileFrontend, VisualEditor and Wikibase (hopefully this reaches you, as I added the projects to subscribers): Please ensure that none of these widgets are ever constructed with multiline: true, as they will throw horrible exceptions in that case. If they do need to be multiline, they should inherit from OO.ui.MultilineTextInputWidget instead. Sorry for the mess :(
I think it is not worthwhile for us to add additional code to deal with this deprecated case, so I'm declining this for OOjs UI.
TASK DETAIL
EMAIL PREFERENCES
To: santhosh, matmarex
Cc: Wikibase, VisualEditor, MobileFrontend, Flow, matmarex, gerritbot, santhosh, Aklapper, Nikerabbit, Lordiis, Adik2382, chapulina, Jrbranaa, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, Nizil, Ixocactus, ferdbold, Amire80, Gryllida, Ricordisamoa, Jsahleen, Arrbee, KartikMistry, Jay8g
Cc: Wikibase, VisualEditor, MobileFrontend, Flow, matmarex, gerritbot, santhosh, Aklapper, Nikerabbit, Lordiis, Adik2382, chapulina, Jrbranaa, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, Nizil, Ixocactus, ferdbold, Amire80, Gryllida, Ricordisamoa, Jsahleen, Arrbee, KartikMistry, Jay8g
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
