| Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality, Wikibase-Quality-Constraints. Herald added a subscriber: Aklapper. |
TASK DESCRIPTION
- SymmetricChecker and InverseChecker use ConnectionCheckerHelper::findStatement.
- ConnectionCheckerHelper::findStatement’s interface was designed for ItemChecker and TargetRequiredClaimChecker, which need to support unknown value and no value, so they can’t just use EntityId objects directly.
- ItemIdSnakValue encapsulates an ItemId, unknown value, or no value, but not other kinds of entity IDs, since “item requires claim” and “target requires claim” constraints only support items as the expected values.
- As an unintended consequence, SymmetricChecker and InverseChecker don’t work on properties, since the expected value in their case is the entity (ID) with the constraint.
The best place to break this up is probably the first bullet point – split findStatement into findStatementWithEntityId and findStatementWithItemIdSnakValue.
TASK DETAIL
EMAIL PREFERENCES
To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331
Cc: Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
