| Lucas_Werkmeister_WMDE updated the task description. (Show Details) |
CHANGES TO TASK DESCRIPTION
>`Special:ConstraintReport` on an item with a statement with a constraint that has exceptions (e. g. Q3033 – I estimate this affects the majority of items with more than a handful of statements) shows this error:
> Fatal exception of type "WikibaseQuality\ConstraintReport\ConstraintCheck\Helper\ConstraintParameterException"
Similarly, a `wbcheckconstraints` API request on such an item (such requests are, for example, performed by the //checkConstraints// gadget each time an item is visited) shows this error:
> {
> "code": "internal_api_error_WikibaseQuality\\ConstraintReport\\ConstraintCheck\\Helper\\ConstraintParameterException",
> "info": "[WXDsswpAEDMAAE176mYAAAAS] Exception caught: The value for the parameter "<span class=\"wbqc-role wbqc-role-constraint-parameter-property\">known_exception</span>" must be an entity, not "<span class=\"wbqc-role wbqc-role-constraint-parameter-value\">Q9712957\u200e</span>"."
> }
This is going to happen on every constraint check (API or special page) for every constraint that has exceptions,e reason for this is that `DelegatingConstraintChecker::checkConstraintsForStatementOnEntity` makes `CostraintParameterParser` parse the constraint exceptions (the items that a constraint doesn’t apply to), but doesn’t catch the `ConstraintParameterException`s that can occur when the exceptions contain malformed data. because I’m a massive idiot: `DelegatingConstraintChecker::checkConstraintsForStatementOnEntity` has `CostraintParameterParser` parse the exceptionsIn the case of the second error message above, but doesn’t botherthere seem to catch the `ConstraintParameterExceptions`be some exception templates that occur when there’s rubbish in the exceptionscontaint Unicode left-to-right marks (U+200E).
> Fatal exception of type "WikibaseQuality\ConstraintReport\ConstraintCheck\Helper\ConstraintParameterException"
Similarly, a `wbcheckconstraints` API request on such an item (such requests are, for example, performed by the //checkConstraints// gadget each time an item is visited) shows this error:
> {
> "code": "internal_api_error_WikibaseQuality\\ConstraintReport\\ConstraintCheck\\Helper\\ConstraintParameterException",
> "info": "[WXDsswpAEDMAAE176mYAAAAS] Exception caught: The value for the parameter "<span class=\"wbqc-role wbqc-role-constraint-parameter-property\">known_exception</span>" must be an entity, not "<span class=\"wbqc-role wbqc-role-constraint-parameter-value\">Q9712957\u200e</span>"."
> }
This is going to happen on every constraint check (API or special page) for every constraint that has exceptions,e reason for this is that `DelegatingConstraintChecker::checkConstraintsForStatementOnEntity` makes `CostraintParameterParser` parse the constraint exceptions (the items that a constraint doesn’t apply to), but doesn’t catch the `ConstraintParameterException`s that can occur when the exceptions contain malformed data. because I’m a massive idiot: `DelegatingConstraintChecker::checkConstraintsForStatementOnEntity` has `CostraintParameterParser` parse the exceptionsIn the case of the second error message above, but doesn’t botherthere seem to catch the `ConstraintParameterExceptions`be some exception templates that occur when there’s rubbish in the exceptionscontaint Unicode left-to-right marks (U+200E).
TASK DETAIL
EMAIL PREFERENCES
To: Lucas_Werkmeister_WMDE
Cc: gerritbot, TerraCodes, Jay8g, Liuxinyu970226, Aklapper, Lucas_Werkmeister_WMDE, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331
Cc: gerritbot, TerraCodes, Jay8g, Liuxinyu970226, Aklapper, Lucas_Werkmeister_WMDE, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
