| Catrope added a comment. |
In T168487#3474933, @SBisson wrote:From the task description:
There should be no highlighting for these rows regardless of whether it's using the original ORES highlighting or the newer highlighting done by RC Page itself.
Note that the patch above doesn't handle the original ORES highlighting.
Good point, I'll fix that.
Also, not sure how wikidata and log entries end up with scores. The ORES extension fetches scores only for RC_EDIT and RC_NEW.[1]
Log entries aren't scored in practice, but I wanted to be paranoid/consistent. Wikidata entries end up with a score because their rc_this_oldid refers to the oldid of the revision on wikidatawiki, but then gets joined against the local (e.g. enwiki) revision table. If the sizes of the two revision tables line up in the right way, that join will succeed and find a score for a completely unrelated local edit.
Cc: SBisson, gerritbot, PokestarFan, Catrope, Halfak, Aklapper, Mattflaschen-WMF, bkowshik, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Avner, Lewizho99, Maathavan, Iniquity, jmatazzoni, Izno, Wikidata-bugs, aude, He7d3r, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
