[Wikidata-bugs] [Maniphest] [Commented On] T154555: Special:SetSiteLink, other SpecialModifyEntity subclasses open master connection on GET

[Ladsgroup]

Ladsgroup added a comment.

I still see lots of similar errors in logstash after deploying it https://logstash.wikimedia.org/goto/d9ac61c9e1b1767fa96dc45a511adc9c:

Expectation (masterConns <= 0) by MediaWiki::main not met (actual: 1):
[connect to 10.64.32.228 (wikidatawiki)]
#0 /srv/mediawiki/php-1.30.0-wmf.14/includes/libs/rdbms/TransactionProfiler.php(164): Wikimedia\Rdbms\TransactionProfiler->reportExpectationViolated()
#1 /srv/mediawiki/php-1.30.0-wmf.14/includes/libs/rdbms/loadbalancer/LoadBalancer.php(678): Wikimedia\Rdbms\TransactionProfiler->recordConnection()
#2 /srv/mediawiki/php-1.30.0-wmf.14/includes/dao/DBAccessBase.php(64): Wikimedia\Rdbms\LoadBalancer->getConnection()
#3 /srv/mediawiki/php-1.30.0-wmf.14/extensions/Wikidata/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityMetaDataLookup.php(211): DBAccessBase->getConnection()
#4 /srv/mediawiki/php-1.30.0-wmf.14/extensions/Wikidata/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityMetaDataLookup.php(94): Wikibase\Lib\Store\Sql\WikiPageEntityMetaDataLookup->selectRevisionInformationMultiple()
#5 /srv/mediawiki/php-1.30.0-wmf.14/extensions/Wikidata/extensions/Wikibase/lib/includes/Store/Sql/PrefetchingWikiPageEntityMetaDataAccessor.php(150): Wikibase\Lib\Store\Sql\WikiPageEntityMetaDataLookup->loadRevisionInformation()
#6 /srv/mediawiki/php-1.30.0-wmf.14/extensions/Wikidata/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php(139): Wikibase\Lib\Store\Sql\PrefetchingWikiPageEntityMetaDataAccessor->loadRevisionInformation()
#7 /srv/mediawiki/php-1.30.0-wmf.14/extensions/Wikidata/extensions/Wikibase/repo/includes/EditEntity.php(280): Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup->getLatestRevisionId()
#8 /srv/mediawiki/php-1.30.0-wmf.14/extensions/Wikidata/extensions/Wikibase/repo/includes/EditEntity.php(307): Wikibase\EditEntity->getLatestRevisionId()
#9 /srv/mediawiki/php-1.30.0-wmf.14/extensions/Wikidata/extensions/Wikibase/repo/includes/EditEntity.php(323): Wikibase\EditEntity->getBaseRevisionId()
#10 /srv/mediawiki/php-1.30.0-wmf.14/extensions/Wikidata/extensions/Wikibase/repo/includes/Specials/SpecialModifyEntity.php(95): Wikibase\EditEntity->getBaseRevision()
#11 /srv/mediawiki/php-1.30.0-wmf.14/extensions/Wikidata/extensions/Wikibase/repo/includes/Specials/SpecialModifyEntity.php(186): Wikibase\Repo\Specials\SpecialModifyEntity->getBaseRevision()
#12 /srv/mediawiki/php-1.30.0-wmf.14/extensions/Wikidata/extensions/Wikibase/repo/includes/Specials/SpecialSetLabelDescriptionAliases.php(244): Wikibase\Repo\Specials\SpecialModifyEntity->getEntityForDisplay()
#13 /srv/mediawiki/php-1.30.0-wmf.14/extensions/Wikidata/extensions/Wikibase/repo/includes/Specials/SpecialModifyEntity.php(209): Wikibase\Repo\Specials\SpecialSetLabelDescriptionAliases->processArguments()
#14 /srv/mediawiki/php-1.30.0-wmf.14/includes/specialpage/SpecialPage.php(522): Wikibase\Repo\Specials\SpecialModifyEntity->execute()
#15 /srv/mediawiki/php-1.30.0-wmf.14/includes/specialpage/SpecialPageFactory.php(578): SpecialPage->run()
#16 /srv/mediawiki/php-1.30.0-wmf.14/includes/MediaWiki.php(287): SpecialPageFactory::executePath()
#17 /srv/mediawiki/php-1.30.0-wmf.14/includes/MediaWiki.php(868): MediaWiki->performRequest()
#18 /srv/mediawiki/php-1.30.0-wmf.14/includes/MediaWiki.php(523): MediaWiki->main()
#19 /srv/mediawiki/php-1.30.0-wmf.14/index.php(43): MediaWiki->run()
#20 /srv/mediawiki/w/index.php(3): include()
#21 {main}

TASK DETAIL

https://phabricator.wikimedia.org/T154555

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel, Ladsgroup
Cc: PokestarFan, aude, Ladsgroup, Lydia_Pintscher, Amire80, daniel, Johan, Glaisher, Nemo_bis, Gilles, PleaseStand, Krenair, Joe, aaron, gerritbot, MZMcBride, Aklapper, Catrope, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Jay8g

_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs