| Smalyshev added a comment. |
I've introduced a cache to reduce number of calls to EntityId::getLocalPart and EntityId::getRepositoryName.
I think we also need to take a good look why splitSerialization is getting called so much. We do not need to do any transformations to the IDs we get from the database - we get Q123, we add prefix to it and we output wd:Q123 or whatever. That should not require calling tons of functions. Yet we do. And we obsessively validate IDs known to be valid. I think we have a case of over-abstraction there or maybe using the same API for clean and dirty input, which is sub-optimal from performance point of view.
TASK DETAIL
EMAIL PREFERENCES
To: Smalyshev
Cc: hoo, Ladsgroup, PokestarFan, Lucas_Werkmeister_WMDE, Smalyshev, daniel, WMDE-leszek, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331
Cc: hoo, Ladsgroup, PokestarFan, Lucas_Werkmeister_WMDE, Smalyshev, daniel, WMDE-leszek, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
