Lucas_Werkmeister_WMDE added a comment.

To summarize an IRC discussion (in an unlogged channel :/ ) –

  • We certainly don’t need a mixture of having hashes for some snaks but not others. To this end, I’ve created WikibaseDataModelSerialization#233, and once version 2.5.0 of that library is released we should use SerializerFactory::OPTION_SERIALIZE_SNAKS_WITHOUT_HASH.
  • We definitely don’t want hashes in the database, and it’s debatable whether we want them in the JSON dumps. (Perhaps we want two kinds of JSON dumps – see T174029.) Elsewhere, we can probably include the hashes. It might not even need to be configurable. (Daniel: “I’m okay with always including the hashes in API output, and output of Special:EntityData.”)
  • This should be announced as, at least, a significant change. If we go for dumps without hashes, it’s a breaking change, because qualifier snaks used to have hashes.

TASK DETAIL
https://phabricator.wikimedia.org/T171607

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Addshore, Aklapper, daniel, Lucas_Werkmeister_WMDE, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to