| abian added a comment. |
In T141859#3549363, @Lucas_Werkmeister_WMDE wrote:(Aside: that first query should probably include “work period (start)”. It seems to be missing a P279 statement.)
I’m not convinced that this is the best approach. Do we really need all the properties for every constraint? I feel like it might make more sense to define the properties to be used on the constraint, and to limit them to a smaller set: for instance, perhaps a contemporary constraint check for “spouse” should only take into account “date of birth” and “date of death”, not “service entry” or “date of official closure”.
Indeed, but, on the one hand, this constraint is applied to many different properties, even P31 and P279. On the other hand, I see no undesirable effects when considering more subproperties than necessary if the difference in computational cost is negligible (no idea for now, but it shouldn't be huge). By defining what subproperties should be considered for the constraint for each property, we are also introducing redundancies and potential inconsistencies with other constraints, mainly with conflicts-with constraint, apart from all the problems mentioned above.
An algorithm that gives us the same outputs as another in almost the same time and with fewer inputs is a better algorithm. If the difference in computational cost wasn't relevant here (no idea if it will finally be or not) and, in addition, the algorithm with more inputs (qualifiers) brings us all the considered problems, I have clear which is the best option.
But consensus should decide, not my point of view... 😇
Cc: Ivan_A_Krestinin, PokestarFan, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Wikibase-Quality-Constraints, abian, Aklapper, GoranSMilovanovic, Soteriaspace, JakeTheDeveloper, QZanden, Agabi10, Izno, Wikidata-bugs, aude, TheDJ, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
