| Mattflaschen-WMF removed projects: Flow, Collaboration-Team-Triage. Mattflaschen-WMF added a comment. |
Thanks for running this check. Flow looks good.
File: /home/reedy/git/mediawiki/core/extensions/Flow/includes/Data/Storage/RevisionStorage.php
> Line 324: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($source as &$row) {
}I reviewed php7_foreach and the above looks fine.
It is not doing anything edge-casey on either of the arrays being iterated ($cacheResult and $source) (no additions or removals to these arrays, no replacements of the whole array).
File: /home/reedy/git/mediawiki/core/extensions/Flow/includes/Import/LiquidThreadsApi/Source.php > Line 195: [Warning] Function argument(s) returned by "func_get_args" might have been modified func_get_args();Turns out they're not.
File: /home/reedy/git/mediawiki/core/extensions/Flow/includes/Repository/TreeRepository.php > Line 365: [Warning] Possible array element creation during by-reference assignment $identityMap[$parent->getAlphadecimal()]['children'][$child] =& $identityMap[$child];This line is a bit tricky.
However, $identityMap[$child] is certainly created before this line, so there's no way two new keys of $identityMap itself are created in this line (and thus no ordering issue between these two).
TASK DETAIL
EMAIL PREFERENCES
To: Mattflaschen-WMF
Cc: Mattflaschen-WMF, Liuxinyu970226, WMDE-leszek, Anomie, Aklapper, Jdforrester-WMF, Addshore, Krinkle, MaxSem, Krenair, Reedy, Minilexikon, Timoavax79, GoranSMilovanovic, TheDragonFire, Maosef, QZanden, EBjune, Orienteerix, Litanwei, Avner, Ddproxy, debt, TerraCodes, SundanceRaphael, Reasno, Gehel, Debenben, Jseddon, JGirault, gabriel-wmde, phabyogi, FloNight, DStrine, Dixtosa, GAllegre, Susannaanas, XenoRyet, Thibaut120094, Izno, Matiia, ferdbold, lxbarth, Wong128hk, Luke081515, Nirmos, Planemad, Wikidata-bugs, Snowolf, Prod, Hydriz, aude, fredw, SPQRobin, AndyRussG, Ebe123, Pcoombe, Huji, Physikerwelt, Pkra, Dinoguy1000, jeblad, jayvdb, Ricordisamoa, MrStradivarius, Lydia_Pintscher, Yurik, Darkdadaah, Arrbee, scfc, KartikMistry, Se4598, Jackmcbarn, Mbch331, Jay8g, Ltrlg, Joe, jeremyb, Legoktm, Tgr
Cc: Mattflaschen-WMF, Liuxinyu970226, WMDE-leszek, Anomie, Aklapper, Jdforrester-WMF, Addshore, Krinkle, MaxSem, Krenair, Reedy, Minilexikon, Timoavax79, GoranSMilovanovic, TheDragonFire, Maosef, QZanden, EBjune, Orienteerix, Litanwei, Avner, Ddproxy, debt, TerraCodes, SundanceRaphael, Reasno, Gehel, Debenben, Jseddon, JGirault, gabriel-wmde, phabyogi, FloNight, DStrine, Dixtosa, GAllegre, Susannaanas, XenoRyet, Thibaut120094, Izno, Matiia, ferdbold, lxbarth, Wong128hk, Luke081515, Nirmos, Planemad, Wikidata-bugs, Snowolf, Prod, Hydriz, aude, fredw, SPQRobin, AndyRussG, Ebe123, Pcoombe, Huji, Physikerwelt, Pkra, Dinoguy1000, jeblad, jayvdb, Ricordisamoa, MrStradivarius, Lydia_Pintscher, Yurik, Darkdadaah, Arrbee, scfc, KartikMistry, Se4598, Jackmcbarn, Mbch331, Jay8g, Ltrlg, Joe, jeremyb, Legoktm, Tgr
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
