| Addshore added a comment. |
Regarding Cognate:
File: /home/reedy/git/mediawiki/core/extensions/Cognate/src/CognateHooks.php
> Line 25: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
> Line 43: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
> Line 54: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();These all look like false positives as long as I understand what this is trying to hint at correctly.
- https://github.com/wikimedia/mediawiki-extensions-Cognate/blob/master/src/CognateHooks.php#L25
- https://github.com/wikimedia/mediawiki-extensions-Cognate/blob/master/src/CognateHooks.php#L43
- https://github.com/wikimedia/mediawiki-extensions-Cognate/blob/master/src/CognateHooks.php#L54
File: /home/reedy/git/mediawiki/core/extensions/Cognate/src/StringHasher.php
> Line 61: [Error] Bitwise shift by 32 bits
hexdec($hexhi) \ 32;Doesn't look like an issue?
https://3v4l.org/54iU5
Maybe it would be an issue on 32 bit systems?
Cognate will already refuse to run on 32 bit systems:
https://github.com/wikimedia/mediawiki-extensions-Cognate/blob/d5c97af4ece85304f27cea60a89d9d59d664e0b0/src/StringHasher.php#L28
TASK DETAIL
EMAIL PREFERENCES
To: Addshore
Cc: Ottomata, gerritbot, Mattflaschen-WMF, Liuxinyu970226, WMDE-leszek, Anomie, Aklapper, Jdforrester-WMF, Addshore, MaxSem, Krenair, Reedy, Minilexikon, Timoavax79, Lordiis, GoranSMilovanovic, TheDragonFire, Maosef, Adik2382, 45Jayjay1969, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, Orienteerix, EnricoCNC, Litanwei, Avner, Lewizho99, Ddproxy, Maathavan, debt, TerraCodes, SundanceRaphael, Reasno, Gehel, Debenben, Jseddon, JGirault, gabriel-wmde, phabyogi, FloNight, DStrine, Dixtosa, Trizek-WMF, GAllegre, Susannaanas, XenoRyet, Thibaut120094, Izno, SBisson, Matiia, ferdbold, lxbarth, Wong128hk, Luke081515, Nirmos, Planemad, Wikidata-bugs, Snowolf, Prod, Hydriz, aude, fredw, SPQRobin, AndyRussG, Ebe123, Pcoombe, Huji, Physikerwelt, Pkra, Dinoguy1000, Gryllida, jeblad, jayvdb, Ricordisamoa, MrStradivarius, Catrope, Lydia_Pintscher, Yurik, Darkdadaah, Arrbee, scfc, KartikMistry, Se4598, Jackmcbarn, Mbch331, Jay8g, Ltrlg, Joe, jeremyb, Legoktm, Tgr
Cc: Ottomata, gerritbot, Mattflaschen-WMF, Liuxinyu970226, WMDE-leszek, Anomie, Aklapper, Jdforrester-WMF, Addshore, MaxSem, Krenair, Reedy, Minilexikon, Timoavax79, Lordiis, GoranSMilovanovic, TheDragonFire, Maosef, Adik2382, 45Jayjay1969, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, Orienteerix, EnricoCNC, Litanwei, Avner, Lewizho99, Ddproxy, Maathavan, debt, TerraCodes, SundanceRaphael, Reasno, Gehel, Debenben, Jseddon, JGirault, gabriel-wmde, phabyogi, FloNight, DStrine, Dixtosa, Trizek-WMF, GAllegre, Susannaanas, XenoRyet, Thibaut120094, Izno, SBisson, Matiia, ferdbold, lxbarth, Wong128hk, Luke081515, Nirmos, Planemad, Wikidata-bugs, Snowolf, Prod, Hydriz, aude, fredw, SPQRobin, AndyRussG, Ebe123, Pcoombe, Huji, Physikerwelt, Pkra, Dinoguy1000, Gryllida, jeblad, jayvdb, Ricordisamoa, MrStradivarius, Catrope, Lydia_Pintscher, Yurik, Darkdadaah, Arrbee, scfc, KartikMistry, Se4598, Jackmcbarn, Mbch331, Jay8g, Ltrlg, Joe, jeremyb, Legoktm, Tgr
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
