Krinkle added a comment.

  1. Move all those libraries to Wikibase git repository
    • pro: dependency problem goes away
    • con: code provided by those libs is no longer versioned as now - all only work with current Wikibase master
    • con: even more code in Wikibase.git
    • con: no way for those libs to by used by other users than Wikibase (but are there any?)
  2. Turn those libs into npm packages and check in them into a particular place in Wikibase git repository to be picked up by RL
    • pro: easy integration with RL (know where files are)
    • pro: libs can be still released and developed independently from Wikibase/MW
    • con: libs are maintained in two places
    • con: needs manual committing after each release of a lib (Composer no longer used)

Regarding Option 1:

Having your own Git repository and being published as npm package (e.g. for third-parties) are not mutually exclusive. You can run npm publish from any directory that contains a package.json file. Whether it's a sub directory of something or even in a Git repo at all is irrelevant from npm's perspective. (This is why for example, in npm, contrary to Composer, the version number must be declared in package.json).

So you can consolidate the best of option 1 and option 2:

  • Option 5: Move those libraries to the Wikibase git repository:
    • pro: dependency problem goes away
    • pro: build step goes away
    • pro: easy integration with RL (know where files are)
    • pro: libs can be still released and published independently from Wikibase/MW
    • pro: libs only maintained in a single place
    • con: even more code in Wikibase.git

This would be my recommendation (as first step).


TASK DETAIL
https://phabricator.wikimedia.org/T174922

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Krinkle, Aklapper, Addshore, Legoktm, greg, Lydia_Pintscher, daniel, thiemowmde, Aleksey_WMDE, Jonas, hoo, aude, demon, WMDE-leszek, GoranSMilovanovic, QZanden, Liudvikas, Izno, Luke081515, Wikidata-bugs, zeljkofilipin, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to