Smalyshev added a comment.

now if you decide to add P1559 (monolingual text) we should not index it in the "statements" elastic field they'll require totally different analyzers (one is an identifier, the other is written language)

I don't currently plan to analyze values in any way, so for statements field they are indexed as keyword. That would be ok for some strings too (e.g. URLs, identifiers, and such) but of course not appropriate for full-text search if we ever want one. But I currently don't plan it yet.

why not item_statements instead of statements?

I see your point, but item_statements doesn't seem much better - first, it's not clear whether it is statements on items or statements having items as values, second, even now values can be any entity ID, not only item ID, and also may accept some strings too. So I agree maybe statements is not great, will think about which one would be better.


TASK DETAIL
https://phabricator.wikimedia.org/T175199

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Smalyshev
Cc: aude, gerritbot, debt, EBernhardson, dcausse, daniel, Aklapper, Smalyshev, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to