| Krinkle added a comment. |
In T174922#3583384, @WMDE-leszek wrote:One concern with the Option 5 I could imagine is that the separation between those libs and the "core" Wikibase is drawn less strict than e.g. when those libs are only pulled in when "building" Wikibase & co (option 4), or when they're technically separate git repos/submodules (option 3).
In addition to the static analysis test @Legoktm suggested, this can also be enforced through unit tests. If the libraries have working unit tests that can be run in these separate repos, they can continue to be run that way when in the Wikibase repo. There shouldn't be any need to run them via MediaWiki QUnit. Check out https://github.com/wikimedia/oojs and https://github.com/wikimedia/unicodejs for examples of simple npm-test libraries that don't involve MediaWiki. The only thing needed is to have the main package.json's test script also execute tests for the individual libraries. This could be as simple as npm install && npm test in each lib directly, or more elaborate/fine-tuned.
Cc: JeroenDeDauw, Krinkle, Aklapper, Addshore, Legoktm, greg, Lydia_Pintscher, daniel, thiemowmde, Aleksey_WMDE, Jonas, hoo, aude, demon, WMDE-leszek, GoranSMilovanovic, QZanden, Liudvikas, Izno, Luke081515, Wikidata-bugs, zeljkofilipin, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
