| Lucas_Werkmeister_WMDE added a comment. |
AIUI, this would be called when editing
Not quite – constraint checks (including the “format” constraint) are currently run when a user who has enabled the checkConstraints gadget views an entity page or saves a statement. (And we plan to enable that gadget by default soon.) And constraint checking for one entity may include dozens of regex checks, especially once we start checking qualifiers and references too.
If we’re going to check the regexes on a microservice, then we might as well use PCRE IMHO, for compatibility’s sake. I don’t think any of the regular regexes on Wikidata result in catastrophic runtime behavior, so if that risk is already mitigated by the microservice, I don’t think we need the extra protection+restrictions of RE2.
TASK DETAIL
EMAIL PREFERENCES
To: Lucas_Werkmeister_WMDE
Cc: Anomie, Smalyshev, tstarling, daniel, GWicke, Joe, Lucas_Werkmeister_WMDE, Krinkle, Aklapper, GoranSMilovanovic, QZanden, Agabi10, Izno, SBisson, Wikidata-bugs, aude, jayvdb, fbstj, RobLa-WMF, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, Legoktm
Cc: Anomie, Smalyshev, tstarling, daniel, GWicke, Joe, Lucas_Werkmeister_WMDE, Krinkle, Aklapper, GoranSMilovanovic, QZanden, Agabi10, Izno, SBisson, Wikidata-bugs, aude, jayvdb, fbstj, RobLa-WMF, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, Legoktm
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
