| Mattflaschen-WMF added a comment. |
In T171027#3628964, @Bawolff wrote:They're not fully redundant, since rc_type for Wikidata is RC_EXTERNAL (from core, thus not Wikidata-specific).
Afaict only wikidata uses it.
That's true (at least for WMF), but as long as it's RC_EXTERNAL in core (not even documented to be Wikidata-y), not (hypothetically) RC_WIKIBASE_TYPE in Wikibase, we can't rely on that.
So AFAICT, it's best to move everything here to use rc_source.
The IN would at best be a range condition (although im not sure mariadb would see it that way because it cant tell its a contiguous range). Usually the range has to be the rightmost part of the index we're using, so i dont think that would work, as the idea is to segregate the table by putting the wikidata stuff by putting that at the leftmost part of the index. (It could maybe do index merge or we could manually UNION, but it seems like mariadb doesnt usually choose that path, and im not sure thats really ideal given how many rows the query already has to look at).
We could have a (rc_source) index (there is already (rc_timestamp)). Or perhaps both (rc_source) and (rc_source, rc_timestamp). I'm not sure if this is a workable approach (I guess it would require an index merge either way); it's just something to consider.
Cc: matej_suchanek, Ankry, Ladsgroup, Lsanabria, Josve05a, Bawolff, greg, Dominicbm, Vriullop, Jmabel, Fae, IKhitron, Johan, Herzi.Pinki, jmatazzoni, Trizek-WMF, Mattflaschen-WMF, KTC, Framawiki, zhuyifei1999, Marostegui, aaron, Andrei_Stroe, Turbojet, Rsocol, Strainu, Jwh, Pyb, Darwinius, Arbnos, Jdforrester-WMF, TheDJ, gerritbot, VladXe, Kf8, Liuxinyu970226, Jay8g, TerraCodes, Iniquity, jcrespo, Reedy, Catrope, Vicpeters, Demidenko, MaxBioHazard, Aklapper, Waytogoeducation, GoranSMilovanovic, Abiyoyo, QZanden, Vali.matei, Jack_who_built_the_house, Minhnv-2809, Poyekhali, Volker_E, Izno, Wong128hk, Luke081515, Wikidata-bugs, Base, aude, GWicke, El_Grafo, Gryllida, putnik, Steinsplitter, Mbch331, Krenair
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
