[Wikidata-bugs] [Maniphest] [Commented On] T177311: 2% of /w/load.php spent in WebStart/onBeforeCreateEchoEvent for Wikibase

[Krinkle]

Krinkle added a comment.

In T177311#3659950, @gerritbot wrote:

Change 382383 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Split Echo hook handlers based on services needed

https://gerrit.wikimedia.org/r/382383

@aude Thanks for the quick patch!

	public static function newFromGlobalState() {
-		$wikibaseClient = WikibaseClient::getDefaultInstance();
-		$settings = $wikibaseClient->getSettings();
+		$settings = WikibaseSettings::getClientSettings();

		return new self(
-			$wikibaseClient->newRepoLinker(),
-			$wikibaseClient->getNamespaceChecker(),
			$settings->getSetting( 'echoIcon' ),
		);

Very nice. I didn't know WikibaseSettings::getClientSettings existed. That also avoids creating WikibaseClient's services.

TASK DETAIL

https://phabricator.wikimedia.org/T177311

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aude, Krinkle
Cc: Lydia_Pintscher, gerritbot, hoo, aude, thiemowmde, Krinkle, Aklapper, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331

_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs