| Lucas_Werkmeister_WMDE added a comment. |
@Lydia_Pintscher I don’t understand why this task was closed as “Resolved” – I’m not aware of any solution.
I think Thiemo’s proposed layout in this comment makes sense (apart from the name problems), and we will need something like that to address several problems in the constraints gadget. It would also be useful to gadget or user script authors.
Regarding the problems:
- The wikibase-snakview-value-container name is already in use – so find another name, we all know naming things is easy ;) but more seriously – surely we can find something. Perhaps wikibase-snakview-value-line?
- Having two containers is odd – hm, in my opinion it kinda makes sense. We have a container for the value with indicator, then another container for just the value, and inside that is the actual value, which is sometimes not even an element (e. g. strings and dates don’t have any surrounding elements, they’re just plain text nodes).
- Breaking existing code – yeah :( I think we should try to at least get some feedback on the new layout from external gadget/script authors before we deploy it. Perhaps there’s an opportunity for that at WikidataCon?
I’ll also copy+paste the (in my opinion) desired behavior of the indicators from T169866:
- When the user starts editing the statement, the indicators should be hidden, but not removed from the DOM. [We can even do the hiding with CSS: .wb-edit .wb-indicators { display: none; }. But they also need to be attached in the DOM somewhere where they won’t be removed.]
- When the user cancels editing the statement, the indicators should be made visible again. This ought to preserve event handlers.
- When the users saves the statement, the indicators should be cleared. User scripts, gadgets etc. can re-add them by subscribing to the hooks from T167870: Add JS hooks for changes to statements.
TASK DETAIL
EMAIL PREFERENCES
To: Lydia_Pintscher, Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, dominic.sauer, gerritbot, thiemowmde, aude, hoo, Lydia_Pintscher, Aklapper, Tamslo, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331
Cc: Lucas_Werkmeister_WMDE, dominic.sauer, gerritbot, thiemowmde, aude, hoo, Lydia_Pintscher, Aklapper, Tamslo, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
