[Wikidata-bugs] [Maniphest] [Edited] T173850: Possible WMF deployed extension PHP 7 issues

[Reedy]

Reedy updated the task description. (Show Details)

CHANGES TO TASK DESCRIPTION

Similar to T173848, output from From https://github.com/sstalle/php7cc

Done for extensions in 1.30.0-wmf.14

```
File: /home/reedy/git/mediawiki/core/extensions/Calendar/Calendar.hooks.php
> Line 23: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/EventLogging/includes/JsonSchema.php
> Line 63: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/EventLogging/includes/ApiJsonSchema.php
> Line 133: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($v as &$properties) {
}


File: /home/reedy/git/mediawiki/core/extensions/OAuth/api/MWOAuthSessionProvider.php
> Line 48: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/OAuth/backend/MWOAuthUtils.php
> Line 114: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/JsonConfig/includes/JCValue.php
> Line 96: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/FlaggedRevs/frontend/specialpages/actions/RevisionReview_body.php
> Line 198: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/Flow/includes/Data/Storage/RevisionStorage.php
> Line 324: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($source as &$row) {
}


File: /home/reedy/git/mediawiki/core/extensions/Flow/includes/Import/LiquidThreadsApi/Source.php
> Line 195: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/Flow/includes/Repository/TreeRepository.php
> Line 365: [Warning] Possible array element creation during by-reference assignment
$identityMap[$parent->getAlphadecimal()]['children'][$child] =& $identityMap[$child];


File: /home/reedy/git/mediawiki/core/extensions/AbuseFilter/includes/AbuseFilterVariableHolder.php
> Line 61: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/CodeReview/backend/CodeRevision.php
> Line 715: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/Gadgets/api/ApiQueryGadgets.php
> Line 178: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($data as $key => &$value) {
}


File: /home/reedy/git/mediawiki/core/extensions/WikimediaIncubator/WikimediaIncubator.class.php
> Line 678: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/Cognate/src/CognateHooks.php
> Line 25: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
> Line 43: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
> Line 54: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/Cognate/src/StringHasher.php
> Line 61: [Error] Bitwise shift by 32 bits
hexdec($hexhi) \ 32;


File: /home/reedy/git/mediawiki/core/extensions/WikidataPageBanner/includes/WikidataPageBanner.hooks.php
> Line 218: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/MapSources/MapSources.hooks.php
> Line 17: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
> Line 54: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
> Line 100: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/DonationInterface/gateway_common/GatewayPage.php
> Line 567: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($fieldRules as &$rule) {
}


File: /home/reedy/git/mediawiki/core/extensions/DonationInterface/gateway_common/gateway.adapter.php
> Line 3330: [Warning] Indirect variable, property or method access
${$var[$key]};
> Line 3334: [Warning] Indirect variable, property or method access
${$var[$subkey]};
> Line 3335: [Warning] Indirect variable, property or method access
${$var[$subkey][$subvalue]};


File: /home/reedy/git/mediawiki/core/extensions/Kartographer/includes/DataModuleLinks.php
> Line 44: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($service->links as &$link) {
}


File: /home/reedy/git/mediawiki/core/extensions/RelatedArticles/includes/Hooks.php
> Line 242: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/CentralAuth/includes/CentralAuthUtils.php
> Line 105: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/Babel/Babel.class.php
> Line 39: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/SecurePoll/includes/main/SpecialSecurePoll.php
> Line 102: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/Scribunto/tests/phpunit/engines/LuaCommon/UstringLibraryTest.php
> Line 54: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($chars as &$c) {
}


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/vendor/wikibase/data-model-services/tests/unit/DataValue/ValuesFinderTest.php
> Line 146: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/vendor/wikimedia/purtle/src/RdfWriterBase.php
> Line 206: [Warning] Possible object property creation during by-reference assignment
$writer->prefixes =& $this->prefixes;


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/vendor/data-values/number/src/DataValues/UnboundedQuantityValue.php
> Line 222: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/vendor/data-values/number/src/DataValues/QuantityValue.php
> Line 245: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/vendor/data-values/number/tests/DataValues/DecimalValueTest.php
> Line 76: [Warning] String containing number in hexadecimal notation
'0x20';


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/vendor/data-values/number/tests/ValueParsers/DecimalParserTest.php
> Line 95: [Warning] String containing number in hexadecimal notation
'0x20';


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/vendor/data-values/number/tests/ValueParsers/BasicNumberUnlocalizerTest.php
> Line 36: [Warning] String containing number in hexadecimal notation
'0x20';
> Line 36: [Warning] String containing number in hexadecimal notation
'0x20';
> Line 103: [Warning] String containing number in hexadecimal notation
'0x20';


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/vendor/data-values/common/tests/ValueParsers/FloatParserTest.php
> Line 80: [Warning] String containing number in hexadecimal notation
'0x20';


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/vendor/data-values/common/tests/ValueParsers/IntParserTest.php
> Line 69: [Warning] String containing number in hexadecimal notation
'0x20';


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/vendor/data-values/data-values/tests/phpunit/DataValueTest.php
> Line 39: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
> Line 87: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/vendor/data-values/data-values/tests/phpunit/NumberValueTest.php
> Line 52: [Warning] String containing number in hexadecimal notation
'0x20';


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/extensions/Wikibase/lib/includes/Summary.php
> Line 160: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
> Line 173: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/extensions/Wikibase/lib/includes/Store/GenericEntityInfoBuilder.php
> Line 158: [Warning] Possible array element creation during by-reference assignment
$this->entityInfo[$idString] =& $this->entityInfo[$targetKey];


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/extensions/Wikibase/lib/includes/Serialization/CallbackFactory.php
> Line 55: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($snakGroup as &$snak) {
}


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/Rdf/RdfBuilderTestData.php
> Line 123: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/Api/SetSiteLinkTest.php
> Line 398: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($site['badges'] as &$dummy) {
}


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/Api/GetClaimsTest.php
> Line 171: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($claimsByProperty as &$claimArray) {
}


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/Api/EntityTestHelper.php
> Line 428: [Warning] Possible adding to array on the last iteration of a by-reference foreach loop
$data[$newKey] = $value;


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/Api/SetReferenceTest.php
> Line 214: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($propertyGroup as &$snak) {
}


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/Parsers/MediaWikiNumberUnlocalizerTest.php
> Line 158: [Warning] String containing number in hexadecimal notation
'0x20';


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/extensions/Wikibase/repo/includes/GenericEventDispatcher.php
> Line 90: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/extensions/Wikibase/repo/includes/Content/DataUpdateAdapter.php
> Line 49: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/Math/MathRenderer.php
> Line 208: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/CirrusSearch/tests/unit/Search/FiltersTest.php
> Line 130: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/CirrusSearch/includes/Util.php
> Line 116: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/CirrusSearch/includes/Search/SearchContext.php
> Line 857: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/CirrusSearch/includes/SearchConfig.php
> Line 213: [Warning] Function argument(s) returned by "func_get_args" might have been modifiedDone for extensions in 1.31.0-wmf.2

```
File: /home/reedy/git/mediawiki/core/extensions/EventLogging/includes/JsonSchema.php
> Line 63: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/EventLogging/includes/ApiJsonSchema.php
> Line 133: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($v as &$properties) {
}


File: /home/reedy/git/mediawiki/core/extensions/Flow/includes/Data/Storage/RevisionStorage.php
> Line 324: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($source as &$row) {
}


File: /home/reedy/git/mediawiki/core/extensions/Flow/includes/Repository/TreeRepository.php
> Line 365: [Warning] Possible array element creation during by-reference assignment
$identityMap[$parent->getAlphadecimal()]['children'][$child] =& $identityMap[$child];


File: /home/reedy/git/mediawiki/core/extensions/Gadgets/api/ApiQueryGadgets.php
> Line 178: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($data as $key => &$value) {
}


File: /home/reedy/git/mediawiki/core/extensions/Cognate/src/StringHasher.php
> Line 61: [Error] Bitwise shift by 32 bits
hexdec($hexhi) << 32;


File: /home/reedy/git/mediawiki/core/extensions/DonationInterface/gateway_common/GatewayPage.php
> Line 578: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($fieldRules as &$rule) {
}


File: /home/reedy/git/mediawiki/core/extensions/DonationInterface/gateway_common/gateway.adapter.php
> Line 3312: [Warning] Indirect variable, property or method access
${$var[$key]};
> Line 3316: [Warning] Indirect variable, property or method access
${$var[$subkey]};
> Line 3317: [Warning] Indirect variable, property or method access
${$var[$subkey][$subvalue]};


File: /home/reedy/git/mediawiki/core/extensions/Kartographer/includes/DataModuleLinks.php
> Line 44: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($service->links as &$link) {
}


File: /home/reedy/git/mediawiki/core/extensions/Wikibase/lib/includes/Store/GenericEntityInfoBuilder.php
> Line 158: [Warning] Possible array element creation during by-reference assignment
$this->entityInfo[$idString] =& $this->entityInfo[$targetKey];


File: /home/reedy/git/mediawiki/core/extensions/Wikibase/lib/includes/Serialization/CallbackFactory.php
> Line 55: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($snakGroup as &$snak) {
}


File: /home/reedy/git/mediawiki/core/extensions/Wikibase/repo/tests/phpunit/includes/Api/SetSiteLinkTest.php
> Line 398: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($site['badges'] as &$dummy) {
}


File: /home/reedy/git/mediawiki/core/extensions/Wikibase/repo/tests/phpunit/includes/Api/GetClaimsTest.php
> Line 170: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($claimsByProperty as &$claimArray) {
}


File: /home/reedy/git/mediawiki/core/extensions/Wikibase/repo/tests/phpunit/includes/Api/EntityTestHelper.php
> Line 428: [Warning] Possible adding to array on the last iteration of a by-reference foreach loop
$data[$newKey] = $value;


File: /home/reedy/git/mediawiki/core/extensions/Wikibase/repo/tests/phpunit/includes/Api/SetReferenceTest.php
> Line 214: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($propertyGroup as &$snak) {
}


File: /home/reedy/git/mediawiki/core/extensions/Wikibase/repo/tests/phpunit/includes/Parsers/MediaWikiNumberUnlocalizerTest.php
> Line 158: [Warning] String containing number in hexadecimal notation
'0x20';


File: /home/reedy/git/mediawiki/core/extensions/Scribunto/tests/phpunit/engines/LuaCommon/UstringLibraryTest.php
> Line 56: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($chars as &$c) {
}


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/vendor/wikibase/data-model-services/tests/unit/DataValue/ValuesFinderTest.php
> Line 146: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/vendor/wikimedia/purtle/src/RdfWriterBase.php
> Line 206: [Warning] Possible object property creation during by-reference assignment
$writer->prefixes =& $this->prefixes;


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/vendor/data-values/common/tests/ValueParsers/FloatParserTest.php
> Line 80: [Warning] String containing number in hexadecimal notation
'0x20';


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/vendor/data-values/common/tests/ValueParsers/IntParserTest.php
> Line 69: [Warning] String containing number in hexadecimal notation
'0x20';


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/vendor/data-values/data-values/tests/phpunit/NumberValueTest.php
> Line 52: [Warning] String containing number in hexadecimal notation
'0x20';


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/extensions/Wikibase/lib/includes/Store/GenericEntityInfoBuilder.php
> Line 158: [Warning] Possible array element creation during by-reference assignment
$this->entityInfo[$idString] =& $this->entityInfo[$targetKey];


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/extensions/Wikibase/lib/includes/Serialization/CallbackFactory.php
> Line 55: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($snakGroup as &$snak) {
}


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/Api/SetSiteLinkTest.php
> Line 398: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($site['badges'] as &$dummy) {
}


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/Api/GetClaimsTest.php
> Line 170: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($claimsByProperty as &$claimArray) {
}


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/Api/EntityTestHelper.php
> Line 428: [Warning] Possible adding to array on the last iteration of a by-reference foreach loop
$data[$newKey] = $value;


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/Api/SetReferenceTest.php
> Line 214: [Warning] Nested by-reference foreach loop, make sure that array modifications (if any) do what you expect
foreach ($propertyGroup as &$snak) {
}


File: /home/reedy/git/mediawiki/core/extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/Parsers/MediaWikiNumberUnlocalizerTest.php
> Line 158: [Warning] String containing number in hexadecimal notation
'0x20';


File: /home/reedy/git/mediawiki/core/extensions/CirrusSearch/includes/SearchConfig.php
> Line 214: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();

...

TASK DETAIL

https://phabricator.wikimedia.org/T173850

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Reedy
Cc: Paladox, Ottomata, gerritbot, Mattflaschen-WMF, Liuxinyu970226, WMDE-leszek, Anomie, Aklapper, Jdforrester-WMF, Addshore, MaxSem, Krenair, Reedy, SilvioAryneutro, Minilexikon, Timoavax79, Lordiis, GoranSMilovanovic, TheDragonFire, Maosef, Adik2382, 45Jayjay1969, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, Orienteerix, EnricoCNC, Litanwei, Avner, Lewizho99, Ddproxy, Maathavan, debt, TerraCodes, Iniquity, SundanceRaphael, Reasno, Gehel, Debenben, Jseddon, JGirault, gabriel-wmde, phabyogi, FloNight, DStrine, Dixtosa, Trizek-WMF, GAllegre, Susannaanas, XenoRyet, Thibaut120094, Izno, SBisson, Matiia, ferdbold, lxbarth, Wong128hk, Luke081515, Nirmos, JAllemandou, Zache, Planemad, Wikidata-bugs, Snowolf, Prod, Hydriz, Base, aude, fredw, SPQRobin, AndyRussG, Ebe123, Pcoombe, Huji, Physikerwelt, Pkra, Dinoguy1000, Gryllida, jeblad, jayvdb, Ricordisamoa, MrStradivarius, Catrope, Lydia_Pintscher, Yurik, Darkdadaah, Arrbee, scfc, KartikMistry, Se4598, Jackmcbarn, Mbch331, Jay8g, Ltrlg, jeremyb, Legoktm, Tgr

_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs