| WMDE-leszek added a comment. |
So my two cents below. Please keep in mind that I don't have much experience in JS development, so I might be saying something which is complete rubbish.
- As far as I understand, using .eslintignore file is a standard and kind of "native" way of defining paths to ignore used by eslint. It is also commonly in numerous JS projects I've seen around.
- I am not entirely convinced that having a part of eslint config in .eslintrc.json, and then part (ignore paths) in grunt file is actually making things more clear.
- Moving this to gruntfile would be "binding" (part of) esling config to a particular task runner. If developers of an extension, or WMF as a whole, decided to move to another JS task runner, all this information would also need to migrated etc. Not that it something which would be a rocket science, it is just making configuration stored in two different places and formats (as said in the point above).
- I can totally understand preferring to have ignore path defined in a single place. On the other hand, I could also imagine the gruntfile might become cluttered if all kind of stuff is moved in there. It might be harder to find the relevant important information if there all kind of minor config also mashed in.
Overall: I have no strong preference on either option. Also, it is clear to me, all "arguments" made by me are really minor stuff. That said, from my perspective I also don't see a reason to "enforce" one or either way on extension/skin authors. This kind of thing seem to me to be something each extension devs could do whatever way they prefer, as long as both way are actually quite "standard" and nothing super weird that would be confusing to outside folks. I wouldn't oppose any decision, though, if this was something which is generally preferred :)
TASK DETAIL
EMAIL PREFERENCES
To: WMDE-leszek
Cc: WMDE-leszek, Aklapper, Samwilson, Paladox, Krinkle, Reedy, Florian, Addshore, Jdforrester-WMF, thiemowmde, hashar, Legoktm, Umherirrender, Lahi, SilvioAryneutro, Timoavax79, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, enigmaeth, rohitt, Zoranzoki21, Dixtosa, Wikidata-bugs, aude, TheDJ, Mbch331
Cc: WMDE-leszek, Aklapper, Samwilson, Paladox, Krinkle, Reedy, Florian, Addshore, Jdforrester-WMF, thiemowmde, hashar, Legoktm, Umherirrender, Lahi, SilvioAryneutro, Timoavax79, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, enigmaeth, rohitt, Zoranzoki21, Dixtosa, Wikidata-bugs, aude, TheDJ, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
