| Philipjohn21 added a comment. |
Hi! Apologies that it's taken a while for me to revisit this and provide thoughts and feedback. Thanks for working on this, I love that this is coming together!
Some thoughts/feedback then:
- The set up page feels unnecessary for a number of reasons;
- Using the term meta API to add fields to the term edit screen is the correct way to add this kind of feature in WordPress
- The setup screen really just duplicates that functionality, with no real benefit when the user can easily use the term edit screen instead
- That setup page will quickly get out of hand. Any site with more than a small number of terms will find that page either incredibly slow to load, or it will completely break under the weight of terms
- It's adding a huge amount of bloat by including Bootstrap and not following core WordPress design principles
- In https://phabricator.wikimedia.org/T138371 you mentioned that "Of course, if option is not activated, plugin will delete all data it added." - I'm not entirely sure of the meaning but I would encourage any deletion of data to be explicitly chosen by the user with a double confirmation to avoid accidentally wiping out all the effort of adding Wikidata IDs
- Looks like you've used a template to create the initial plugin framework - those often add lots of unnecessary files so I'd encourage you to do a cleanup when you're nearing completion to remove anything that isn't strictly necessary and also to ensure the comments are all relevant :)
Give me a shout when you're nearing completion and I'll do a full code review too. Looks like there's still a bunch of debugging going on in there so I'll leave you to that :)
TASK DETAIL
EMAIL PREFERENCES
To: Zeko, Philipjohn21
Cc: Zppix, Pigsonthewing, Aklapper, Tramullas, abian, Lydia_Pintscher, Esh77, DanBri, Framawiki, Mbch331, Samwilson, Philipjohn21, Zeko, Lahi, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, Psychoslave, Wikidata-bugs, aude, TheDJ
Cc: Zppix, Pigsonthewing, Aklapper, Tramullas, abian, Lydia_Pintscher, Esh77, DanBri, Framawiki, Mbch331, Samwilson, Philipjohn21, Zeko, Lahi, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, Psychoslave, Wikidata-bugs, aude, TheDJ
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
