| thiemowmde added subscribers: Lydia_Pintscher, thiemowmde, hoo, daniel. thiemowmde triaged this task as "Normal" priority. thiemowmde moved this task from incoming to ready to go on the Wikidata board. thiemowmde added projects: MediaWiki-extensions-WikibaseRepository, Need-volunteer. thiemowmde added a comment. |
Analysis:
- HtmlUrlFormatter currently hard-codes rel="nofollow" as well as class="external free".
- "nofollow" as well as "external" are required for the reasons explained above.
- The "free" specifies the link type further and should be set if "link text equals URL", see https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/parser/Parser.php;1b13888ed6bd09731f10045650714a3392bb55df$1862. This is true for the URL data type, but not for external identifiers.
- HtmlExternalIdentifierFormatter misses all this.
- A quick fix should be to add rel="nofollow" as well as class="external" to HtmlExternalIdentifierFormatter.
- A better solution might be to utilize MediaWiki core's Linker::makeExternalLink in both formatters.
TASK DETAIL
EMAIL PREFERENCES
To: thiemowmde
Cc: daniel, hoo, thiemowmde, Lydia_Pintscher, Liuxinyu970226, revi, ChristianKl, Nemo_bis, Aklapper, Lahi, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, Wikidata-bugs, aude, TheDJ, Mbch331
Cc: daniel, hoo, thiemowmde, Lydia_Pintscher, Liuxinyu970226, revi, ChristianKl, Nemo_bis, Aklapper, Lahi, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, Wikidata-bugs, aude, TheDJ, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
